Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/zipkin] chore: 👷 ✅ Add VIB tests #71761

Merged
merged 2 commits into from
Sep 2, 2024
Merged

[bitnami/zipkin] chore: 👷 ✅ Add VIB tests #71761

merged 2 commits into from
Sep 2, 2024

Conversation

javsalgar
Copy link
Contributor

Description of the change

This PR introduces VIB integration for the new bitnami/zipkin container. It adds goss tests for the container, ensuring the container performs as expected.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/zipkin] Add goss tests for VIB integration
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@javsalgar
[bitnami/zipkin] chore: 👷 ✅ Add VIB tests
bb74f22 
Signed-off-by: Javier J. Salmerón García <[email protected]>
@javsalgar
chore: 🔧 Update references
fe996d0 
Signed-off-by: Javier J. Salmerón García <[email protected]>
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Sep 2, 2024
@github-actions github-actions bot requested a review from dgomezleon September 2, 2024 15:15
dgomezleon
dgomezleon approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javsalgar javsalgar merged commit ab7d579 into main Sep 2, 2024
15 checks passed
@javsalgar javsalgar deleted the test/zipkin-vib branch September 2, 2024 15:20
@github-actions github-actions bot added the solved label Sep 2, 2024
nenych pushed a commit to nenych/containers that referenced this pull request Sep 3, 2024
@javsalgar
[bitnami/zipkin] chore: 👷 ✅ Add VIB tests (bitnami#71761)
8878127 
* [bitnami/zipkin] chore: 👷 ✅ Add VIB tests

Signed-off-by: Javier J. Salmerón García <[email protected]>

* chore: 🔧 Update references

Signed-off-by: Javier J. Salmerón García <[email protected]>

---------

Signed-off-by: Javier J. Salmerón García <[email protected]>
Signed-off-by: nenych <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgomezleon dgomezleon dgomezleon approved these changes

Assignees

@dgomezleon dgomezleon

Labels
bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javsalgar @dgomezleon @bitnami-bot