Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: avoid running ldd against static binaries #73962

Merged
merged 1 commit into from
Oct 25, 2024
Merged

ci: avoid running ldd against static binaries #73962

merged 1 commit into from
Oct 25, 2024

Conversation

juan131
Copy link
Contributor

@juan131 juan131 commented Oct 25, 2024

Description of the change

This PR ensures we ensure the target executables we're inspecting looking for missing libraries aren't statically compiled.

Benefits

Avoiding errors like the one below:

[INFO][goss-cli] Command: check-linked-libraries: stderr:  	not a dynamic executable
[INFO][goss-cli] Command: check-linked-libraries: stderr:  	not a dynamic executable
[INFO][goss-cli] Command: check-linked-libraries: stderr:  	not a dynamic executable

Possible drawbacks

None

Applicable issues

None

Additional information

N/A

@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Oct 25, 2024
@github-actions github-actions bot requested a review from jotamartos October 25, 2024 14:51
@juan131 juan131 merged commit de684bd into bitnami:main Oct 25, 2024
15 checks passed
@juan131 juan131 deleted the ci/common-linked-libraries-test branch October 25, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongomgra gongomgra gongomgra approved these changes

@jotamartos jotamartos Awaiting requested review from jotamartos

Assignees

@jotamartos jotamartos

Labels
bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juan131 @gongomgra @jotamartos @bitnami-bot