-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/postgresql-pgpool] encrypt health check passwords inside pgp… #74021
[bitnami/postgresql-pgpool] encrypt health check passwords inside pgp… #74021
Conversation
…ool.conf Signed-off-by: Yukha Dharmeswara <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please test it using the docker-compose.yaml included in bitnami/pgpool? I executed a quick test building the image with these changes, a using it with the docker-compose. It kept showing these logs:
...
pgpool-1 | 2024-10-31 08:35:56.880: main pid 1: LOG: find_primary_node: make_persistent_db_connection_noerror failed on node 0
pgpool-1 | 2024-10-31 08:35:56.882: main pid 1: LOG: find_primary_node: make_persistent_db_connection_noerror failed on node 1
pgpool-1 | 2024-10-31 08:35:57.890: main pid 1: LOG: find_primary_node: make_persistent_db_connection_noerror failed on node 0
pgpool-1 | 2024-10-31 08:35:57.892: main pid 1: LOG: find_primary_node: make_persistent_db_connection_noerror failed on node 1
...
Also, values for sr_check_password
and health_check_password
were empty in pgpool.conf
bitnami/pgpool/4/debian-12/rootfs/opt/bitnami/scripts/libpgpool.sh
Outdated
Show resolved
Hide resolved
@dgomezleon My bad, I've mistakenly put |
08cfb6b
to
5747864
Compare
…ool.conf Signed-off-by: Yukha Dharmeswara <[email protected]>
5747864
to
d7c01c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Description of the change
Fix password leak
sr_check_password
andhealth_check_password
onpgpool.conf
(by default has644
permission) usingpg_enc
andpg_md5
.Benefits
Hides
sr_check_password
&health_check_password
Possible drawbacks
No drawback
Applicable issues
Additional information