Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update step.yml - added android project type tag #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

viktorbenei
Copy link
Contributor

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a MAJOR/MINOR/PATCH version update

Context

Changes

Investigation details

Decisions

@viktorbenei viktorbenei requested a review from ofalvai July 8, 2023 10:12
@@ -12,6 +12,9 @@ support_url: https://github.com/bitrise-steplib/bitrise-step-activate-gradle-rem
type_tags:
- utility

project_type_tags:
- android
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to target Flutter and React Native too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those supported / tested?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, both of them are supported because the Android side of a RN/Flutter project is a plain Gradle project. Maybe some Flutter/RN specific tasks are marked as non-cacheable, but the rest of the common build logic should benefit from caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants