Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsigned_int unpacking #1267

Merged
merged 3 commits into from
Aug 23, 2018
Merged

unsigned_int unpacking #1267

merged 3 commits into from
Aug 23, 2018

Conversation

pmconrad
Copy link
Contributor

@pmconrad pmconrad commented Aug 19, 2018 •
edited by abitmore
Loading

Resolves #993 and #1088.

TODO:

abitmore
abitmore reviewed Aug 19, 2018
View reviewed changes
programs/js_operation_serializer/main.cpp Outdated
@@ -122,7 +122,6 @@ template<> struct js_name<fc::uint160> { static std::string name(){ retu
template<> struct js_name<fc::sha224> { static std::string name(){ return "bytes 28"; } };
template<> struct js_name<fc::sha256> { static std::string name(){ return "bytes 32"; } };
template<> struct js_name<fc::unsigned_int> { static std::string name(){ return "varuint32"; } };
template<> struct js_name<fc::signed_int> { static std::string name(){ return "varint32"; } };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually JS code is using varint32 everywhere but not varuint32. Will submit an issue there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, should we rename that to varuint64?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so.
JS code need to be fixed anyway.

@abitmore abitmore mentioned this pull request Aug 19, 2018
Open
@pmconrad pmconrad mentioned this pull request Aug 19, 2018
Merged
@abitmore
Copy link
Member 

[ 93%] Building CXX object libraries/plugins/elasticsearch/CMakeFiles/graphene_elasticsearch.dir/elasticsearch_plugin.o
�
Broadcast message from root@travis-job-2cd07e9d-7fb4-490c-8b3e-31a13c875a31
	(unknown) at 22:14 ...
The system is going down for power off NOW!
[ 94%] Linking CXX static library libgraphene_witness.a

Restarted.

@abitmore abitmore merged commit d382ac8 into develop Aug 23, 2018
@abitmore abitmore deleted the 993_un_signed_int_unpacking branch August 23, 2018 00:03
This was referenced Aug 23, 2018
Closed
Closed
@TheTaconator TheTaconator mentioned this pull request Oct 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abitmore abitmore abitmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201810 - Feature Release
Development

Successfully merging this pull request may close these issues.
2 participants
@pmconrad @abitmore