Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ruff debris when specified #71

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Remove ruff debris when specified #71

merged 1 commit into from
Sep 19, 2023

Conversation

miketheman
Copy link
Contributor

No description provided.

@miketheman
Copy link
Contributor Author

Hmm, not sure what the test failures are all about.

@miketheman
Copy link
Contributor Author

Looks like it's bombing on trying to upload a coverage report. Are you certain that Pull Requests have access to the token?

pyclean/.github/workflows/test.yml

Line 46 in d7bbe29

project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}

@bittner
Copy link
Owner

bittner commented Sep 19, 2023

Can you please try to rebase your PR? The test should now pass.

@bittner bittner added the enhancement New feature or request label Sep 19, 2023
@miketheman
Copy link
Contributor Author

Rebased!

@bittner
Copy link
Owner

bittner commented Sep 19, 2023

Still failing, that's odd. It seems like that's how GitHub Repository Secrets work:

Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork.

Not sure how I should set up Codacy in GHA other than what I did. 😟

The changes look good for me, though. Hence merging! 🚀

@bittner bittner merged commit 5b25a89 into bittner:main Sep 19, 2023
3 of 27 checks passed
@bittner
Copy link
Owner

bittner commented Sep 19, 2023

Thanks for your contribution! 💯

@bittner
Copy link
Owner

bittner commented Sep 20, 2023

Released v2.7.5 on PyPI, which ships this feature. ✔️

@miketheman miketheman deleted the clear-up-ruff branch September 20, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bittner bittner bittner approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miketheman @bittner