PM-9000 - User can save empty PIN (whitespaces) (#779)

bitwarden · Jul 31, 2024 · 5c84cbc · 5c84cbc
1 parent b0a55c4
commit 5c84cbc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/BitwardenShared/UI/Platform/Settings/Settings/AccountSecurity/AccountSecurityProcessor.swift b/BitwardenShared/UI/Platform/Settings/Settings/AccountSecurity/AccountSecurityProcessor.swift
@@ -305,7 +305,7 @@ final class AccountSecurityProcessor: StateProcessor<
     private func toggleUnlockWithPIN(_ isOn: Bool) {
         if isOn {
             coordinator.showAlert(.enterPINCode { pin in
-                guard !pin.isEmpty else { return }
+                guard !pin.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty else { return }
 
                 do {
                     let userHasMasterPassword = try await self.services.stateService.getUserHasMasterPassword()

diff --git a/...nShared/UI/Platform/Settings/Settings/AccountSecurity/AccountSecurityProcessorTests.swift b/...nShared/UI/Platform/Settings/Settings/AccountSecurity/AccountSecurityProcessorTests.swift
@@ -492,7 +492,19 @@ class AccountSecurityProcessorTests: BitwardenTestCase { // swiftlint:disable:th
 
         let alert = try XCTUnwrap(coordinator.alertShown.last)
         try await alert.tapAction(title: Localizations.submit)
+        XCTAssertFalse(subject.state.isUnlockWithPINCodeOn)
+    }
+
+    /// `receive(_:)` with `.toggleUnlockWithPINCode` displays an alert and updates the state when submit has been
+    /// pressed but an empty pin was passed.
+    func test_receive_toggleUnlockWithPINCode_toggleOn_withWhitespacePIN() async throws {
+        stateService.activeAccount = .fixture()
+        subject.state.isUnlockWithPINCodeOn = false
+        subject.receive(.toggleUnlockWithPINCode(true))
 
+        let alert = try XCTUnwrap(coordinator.alertShown.last)
+        try alert.setText(" ", forTextFieldWithId: "pin")
+        try await alert.tapAction(title: Localizations.submit)
         XCTAssertFalse(subject.state.isUnlockWithPINCodeOn)
     }