Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 'release/2024.10-rc1' into 'main' #1071

Closed
wants to merge 6 commits into from

Conversation

KatherineInCode
Copy link
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Logo
Checkmarx One – Scan Summary & Details67e23b11-cd9a-487f-9bf2-ce1faca6ea0d

No New Or Fixed Issues Found

@KatherineInCode
Copy link
Contributor Author

@fedemkr It looks like the endless-loading commit is now causing a merge conflict with main :( It looks like it's just git having trouble understanding two different changes; is it something you could fix?

@KatherineInCode KatherineInCode added the hold This shouldn't be merged yet label Oct 25, 2024
matt-livefront and others added 2 commits October 28, 2024 16:08
Co-authored-by: Federico Maccaroni <[email protected]>
Co-authored-by: Pranish <[email protected]>
Co-authored-by: aj-rosado <[email protected]>
Co-authored-by: Phil Cappelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold This shouldn't be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants