fix docker image building

.github/workflows/ci.yml

@@ -45,7 +45,7 @@ jobs:
           ruby-version: 3.2.2
       - uses: actions/setup-node@v2-beta
         with:
-          node-version: '12'
+          node-version: '16'
       - run: npm install -g yarn
       - uses: nanasess/setup-chromedriver@master
       - name: Build and run tests

Dockerfile

@@ -5,24 +5,28 @@ FROM cimg/ruby:${RUBY_VERSION}-node
 ENV HOME=/app
 WORKDIR /app
 
+
 # ENV SSL_CERT_DIR=/etc/ssl/certs
 # ENV SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt
 
-# Install NodeJS
-RUN sudo apt-get update
-# RUN curl -fsSL https://deb.nodesource.com/setup_14.x | bash -
-# RUN sudo apt-get install -y nodejs
-# RUN npm install yarn -g
-
 ENV CURL_CONNECT_TIMEOUT=0 CURL_TIMEOUT=0 GEM_PATH="$HOME/vendor/bundle/ruby/${RUBY_VERSION}:$GEM_PATH" LANG=${LANG:-en_US.UTF-8} PATH="$HOME/bin:$HOME/vendor/bundle/bin:$HOME/vendor/bundle/ruby/${RUBY_VERSION}/bin:$PATH" RACK_ENV=${RACK_ENV:-production} RAILS_ENV=${RAILS_ENV:-production} RAILS_SERVE_STATIC_FILES=${RAILS_SERVE_STATIC_FILES:-enabled} SECRET_KEY_BASE=${SECRET_KEY_BASE:-PLACEHOLDERSECRETBASEKEY}
 
 # Cache bundler
 COPY Gemfile /app/Gemfile
 COPY Gemfile.lock /app/Gemfile.lock
+
+# circleci-image specific
+RUN sudo chown circleci:circleci /app/Gemfile.lock
+
 RUN bundle config set --local path 'vendor/bundle'
 RUN bundle config set --local without 'development test'
 RUN bundle install --jobs 4 --retry 3
 
 COPY . /app
+
+# circleci-image specific
+RUN sudo chown -R circleci:circleci /app
+RUN sudo chown -R circleci:circleci /tmp
+
 RUN yarn install
 RUN RAILS_ENV=production NODE_ENV=production DATABASE_URL=postgresql://localhost/dummy_url bundle exec rake assets:precompile

Gemfile

@@ -27,7 +27,7 @@ gem 'jquery-ui-rails', '6.0.1'
 gem 'bootstrap-sass', '~> 3.4'
 gem 'govuk_frontend_toolkit', '~> 3.1.0'
 gem 'govuk_template', '0.12.0'
-gem 'uglifier', '>= 2.7.2'
+gem "terser", "~> 1.1"
 gem 'js_cookie_rails', '2.1.4'
 gem 'ckeditor'
 gem 'webpacker'

Gemfile.lock

@@ -699,6 +699,8 @@ GEM
     statesman (11.0.0)
     stringio (3.0.9)
     temple (0.8.2)
+    terser (1.1.20)
+      execjs (>= 0.3.0, < 3)
     thor (1.3.0)
     thread_safe (0.3.6)
     tilt (2.0.11)
@@ -712,8 +714,6 @@ GEM
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     uber (0.1.0)
-    uglifier (4.2.0)
-      execjs (>= 0.3.0, < 3)
     unicode-display_width (1.8.0)
     unicode_utils (1.4.0)
     vigilion-rails (2.1.0)
@@ -845,9 +845,9 @@ DEPENDENCIES
   sprockets (~> 3.7.2)
   sprockets-rails (>= 2.0.0)
   statesman (~> 11.0)
+  terser (~> 1.1)
   timecop
   turnip (~> 4.4.0)
-  uglifier (>= 2.7.2)
   vigilion (~> 1.0.4)!
   vigilion-rails (~> 2.1.0)
   virtus

config/environments/production.rb

@@ -1,4 +1,3 @@
-require 'uglifier'
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 
@@ -29,7 +28,8 @@
   }
 
   # Compress JavaScripts and CSS.
-  config.assets.js_compressor = Uglifier.new(compress: { unused: false })
+  config.assets.js_compressor = :terser
+
 
   # config.assets.css_compressor = :sass