Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deletion of support letter attachments #593

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

TheDancingClown
Copy link
Contributor

@TheDancingClown TheDancingClown commented Sep 12, 2023

📝 A short description of the changes

  • supporter_fields - this view displays saved support letters. The Remove button was not destroying the records from the database, only the document so adding in the url and also passing this url as a data attribute along with the remove-supporter class which applies method: delete
  • support_letter - fixed aria label
  • supporter_fields_placeholder - remove button deleted as ID not present when removing newly added support letter

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

@TheDancingClown TheDancingClown marked this pull request as draft September 12, 2023 11:06
@TheDancingClown TheDancingClown marked this pull request as ready for review September 12, 2023 12:34
@TheDancingClown TheDancingClown merged commit e8a780e into main Sep 12, 2023
2 checks passed
@TheDancingClown TheDancingClown deleted the supporters branch September 12, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants