-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add transform point and points #409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: testing
Auto-labelled
type: examples
Auto-labelled for ex/*, example/* and examples/* branches
type: enhancement
Auto-labelled for feat/* and feature/* branches
labels
Aug 8, 2023
bjlittle
added
the
breaking-change
Auto-labelled for break/*, breaking/* and breaking-change/* branches
label
Aug 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #409 +/- ##
==========================================
+ Coverage 85.25% 85.80% +0.55%
==========================================
Files 62 64 +2
Lines 3363 3509 +146
==========================================
+ Hits 2867 3011 +144
- Misses 496 498 +2
|
bjlittle
force-pushed
the
feat/transform-points
branch
2 times, most recently
from
September 11, 2023 21:41
0ed9ec9
to
66943a6
Compare
bjlittle
force-pushed
the
feat/transform-points
branch
from
September 15, 2023 10:42
521766e
to
5702089
Compare
github-actions
bot
removed
the
type: examples
Auto-labelled for ex/*, example/* and examples/* branches
label
Sep 15, 2023
tkoyama010
reviewed
Sep 16, 2023
Co-authored-by: Tetsuo Koyama <[email protected]>
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
tkoyama010
approved these changes
Sep 16, 2023
Awesome, thanks @tkoyama010 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
Auto-labelled for break/*, breaking/* and breaking-change/* branches
scipy 2023
type: enhancement
Auto-labelled for feat/* and feature/* branches
type: testing
Auto-labelled
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR extends the
geovista.transform
API to also supporttransform_point
andtransform_points
, alongside the already existingtransform_mesh
function.I've been building up to this PR for a long while, but it's the first step in opening up some of the core functionality to allow users the ability to manipulate meshes for more complex workflows, rather than just rendering them in a scene.
Test coverage:
geovista.transform.transform_point
geovista.transform.transform_points