Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix geoplotter actor return typing #439

Merged
merged 1 commit into from
Sep 16, 2023
Merged

fix geoplotter actor return typing #439

merged 1 commit into from
Sep 16, 2023

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Sep 16, 2023

🚀 Pull Request

Description

Use the correct type annotation for geovista.GeoPlotterBase methods, which return a pyvista.Actor and not a vtk.vtkActor.


@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #439 (e76ff66) into main (fe39420) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   85.80%   85.80%           
=======================================
  Files          64       64           
  Lines        3509     3509           
=======================================
  Hits         3011     3011           
  Misses        498      498           

@bjlittle bjlittle merged commit dc4c195 into main Sep 16, 2023
@bjlittle bjlittle deleted the geoplotter-actor branch September 16, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant