Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cartographic add_points #442

Merged
merged 8 commits into from
Sep 18, 2023
Merged

Conversation

bjlittle
Copy link
Owner

🚀 Pull Request

Description

The PR implements the geovista.geoplotter.GeoPlotterBase.add_points method, as a convenience to pyvista.Plotter.add_points with cartographic awareness.


@github-actions github-actions bot added type: testing Auto-labelled type: examples Auto-labelled for ex/*, example/* and examples/* branches type: enhancement Auto-labelled for feat/* and feature/* branches labels Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #442 (9e08aa8) into main (0948b72) will increase coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   85.85%   86.23%   +0.37%     
==========================================
  Files          65       66       +1     
  Lines        3520     3617      +97     
==========================================
+ Hits         3022     3119      +97     
  Misses        498      498              
Files Changed Coverage Δ
tests/geometry/test_coastlines.py 100.00% <100.00%> (ø)
tests/geoplotter/test_add_points.py 100.00% <100.00%> (ø)
tests/transform/test_transform_point.py 100.00% <100.00%> (ø)

@bjlittle bjlittle force-pushed the feat/GeoPlotterBase.add_points branch from 07f1007 to 9e08aa8 Compare September 18, 2023 13:22
@bjlittle bjlittle merged commit e5eee73 into main Sep 18, 2023
@bjlittle bjlittle deleted the feat/GeoPlotterBase.add_points branch September 18, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Auto-labelled for feat/* and feature/* branches type: examples Auto-labelled for ex/*, example/* and examples/* branches type: testing Auto-labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant