Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable off-screen rendering of examples #455

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Enable off-screen rendering of examples #455

merged 2 commits into from
Sep 25, 2023

Conversation

bjlittle
Copy link
Owner

🚀 Pull Request

Description

This PR allows the off_screen kwarg to be passed to the main function of the geovista.examples scripts. This enables the ability to call the importable main function of the examples for GHA CI image testing with off_screen=True.


@github-actions github-actions bot added the type: examples Auto-labelled for ex/*, example/* and examples/* branches label Sep 25, 2023
@bjlittle bjlittle changed the title Ex/off screen Enable off-screen rendering of examles Sep 25, 2023
@bjlittle bjlittle changed the title Enable off-screen rendering of examles Enable off-screen rendering of examples Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #455 (7a108ce) into main (5052883) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files          66       66           
  Lines        3617     3617           
=======================================
  Hits         3119     3119           
  Misses        498      498           

@bjlittle bjlittle requested a review from tkoyama010 September 25, 2023 17:07
@bjlittle bjlittle merged commit b65a927 into main Sep 25, 2023
18 checks passed
@bjlittle bjlittle deleted the ex/off-screen branch September 25, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: examples Auto-labelled for ex/*, example/* and examples/* branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant