Remove the has_admin_rights property #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with vhost. Instead, let rabbitmq handles the user authorization and just wrap http 401 (unauthorized) into our own PermissionError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to remove the has_admin_rights and replace it with a
Client._callmethod that turns HTTP 401 (unauthorized) into PermissionError.I think this is a better approach because otherwise has_admin_rights will end up having to exactly replicate the authorization logic of rabbitmq to handle all the corner cases. This seems hard and unnecessary. I think pyrabbit should just provide wrapper around the HTTP API without trying to be too smart.
This fixes problems with vhost-only users, like #39