Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to go 1.21 #10

Merged
merged 2 commits into from
Nov 20, 2023
Merged

chore(deps): update to go 1.21 #10

merged 2 commits into from
Nov 20, 2023

Conversation

GeckoSplinter
Copy link

No description provided.

@GeckoSplinter GeckoSplinter requested review from dbourdrez and a team November 16, 2023 16:29
@@ -33,7 +33,7 @@ func main() {
}

// If an envoy API was set and config is set to wait on envoy
if config.EnvoyAdminAPI != "" && config.StartWithoutEnvoy == false {
if config.EnvoyAdminAPI != "" && !config.StartWithoutEnvoy {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat code improvement! 😃

Copy link
Member

@jbfavre jbfavre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@frgaudet & @Kassad38 could you please have a closer look?

@frgaudet frgaudet merged commit 423383c into master Nov 20, 2023
1 check passed
@frgaudet frgaudet deleted the update-deps branch November 20, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants