Implement rudimentary gaussian blur #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the regex based path parser with a simpler version.
Because filters like mask need to facilitate painting to an off-screen buffer, we extract the logic for this into a separate class outside of Mask. Then the size of the buffer is first adjusted to suit the installed filters. After applying the filters the mask is painted as usual. Notably this implementation currently doesn't support any filter specific attributes such as 'in', 'feOffset', 'feMergeMode' etc.
This doesn't yet do the recommended optimization for standard deviations larger than 2, replacing the gaussian kernel by successive box blurs.
If the diagram is painted to a JComponent make it available s.t. it can be used as the ImageObserver, when painting images. Otherwise they may not be fully loaded when painting.
This avoids unnecessary calculations when presenting the svg in a GUI. We only do this if we are painting to a component as it wastes memory otherwise.
|
Thanks for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a rudimentary gaussian blur filter.
Because filters like mask need to facilitate painting to an off-screen buffer,
we extract the logic for this into a separate class outside of Mask.
Then the size of the buffer is first adjusted to suit the installed filters.
After applying the filters the mask is painted as usual.
Notably this implementation currently doesn't support any filter specific
attributes such as 'in', 'feOffset', 'feMergeMode' etc.
This implementation is capable of rendering the logo from #44, though it isn't particularly fast.
This PR includes the commit from #81, as it was necessary for the logo in #44 to load correctly.