Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: run goimports-reviser happy #548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

zchee
Copy link

@zchee zchee commented Sep 4, 2024

Format the import section with the go run github.com/incu6us/goimports-reviser/v3@latest ./...


It's Go's idioms, but this change is very huge. I respect your opinions.

Signed-off-by: Koichi Shiraishi <[email protected]>
@blacktop
Copy link
Owner

blacktop commented Sep 4, 2024

Ah, so this just groups the: stdlib, external and internal imports together ?

@zchee
Copy link
Author

zchee commented Sep 4, 2024

@blacktop Yes. It should similar to use goimports.
Ref: https://google.github.io/styleguide/go/decisions#import-grouping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants