Make caching console messages consistent with Laravel core #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @hempsworth, this looks good. It's just that we'll have to drop support for some PHP/Laravel versions. Could you either make this backwards compatible with the current supported versions or send in a separate PR first to drop PHP 7.4, 8.0 and Laravel v8? |
|
Hi @driesvints - as Laravel 9 is no longer getting security updates we could possibly drop support for Laravel < 10 and therefore PHP < 8.1? If you're happy with that I can pull together a PR accordingly 👍 |
|
Let's just keep Laravel v9 for now if it supports the components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a purely aesthetic change, to make the console output more consistent with Laravel core caching commands. Also updates the related tests.
It scratches my own itch, so I don't see this mismatch in my deployment output 😄