-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Goose health bar #144
base: main
Are you sure you want to change the base?
Conversation
Hey @Cormwww ! It looks like you need to update your title to include "feat" |
HEy @Cormwww ..looks like it's still failing. Try this feat: Goose health bar like with the exact casing . Hope that helps!!! And then I'll get someone to review this ASAP |
I changed all of the variable names in the healthbar.py file is that the only place that I need to change the casing for, if I don't need to change the variables any more should I create a new pr or should we just stay with this one? Also thanks for sticking through with me on this issue! |
No problem. I mean to say update the title :D of your PR to say
with the colons etc right now it says |
would this make sense to weave in to the main https://github.com/block-open-source/goose/blob/main/src/goose/cli/main.py as an optional code path? also any info on what it should look like? (just not sure what a healthbar is) |
Moved Import statement to the top.
@Cormwww can you write up in the PR description how to validate/test this out best? |
Summary: This PR introduces a configurable health bar for monitoring the key metrics of an active goose session. The health bar displays the following metrics: Exchange token count
|
👋 @Cormwww! Thanks for your contribution Goose! I'm trying to run this from your fork, but having some issues being able to successfully run the goose_session.py script. Specifically, running into an error import services A couple questions: was the intent here to have a separate health bar that runs in a separate window outside of the main goose session (https://github.com/Cormwww/goose/blob/main/src/goose/cli/session.py)? That's the way it currently looks, but I might be missing some context there. Also, a couple of other comments to help with the integration into Goose. It would be great to integrate this into the main goose loop so the the metrics are updated in the health bar as the loop runs. As @michaelneale mentioned this should be an optional path with something like |
Hey @Cormwww any updates? I know that the end of Hacktoberfest is right around the corner and we want this tPR to count for you! |
I put the HealthBar class in a separate utility module like services/health_bar.py for better code organization.
Integrated the health bar in your session management logic, inside goose_session.py or the equivalent.
In the entry point (like main.py), trigger the session and health bar display.
Optionally, I made it configurable using a configuration file such as config.json or environment variables.