feat: give synopsis get_hints tool to fetch relevant developer hints from local context store #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamchau
reviewed
Oct 21, 2024
src/goose/cli/session.py
Outdated
| @@ -218,6 +218,8 @@ def reply(self) -> None: | |||
| for tool_use in response.tool_use: | |||
| tool_result = self.exchange.call_function(tool_use) | |||
| content.append(tool_result) | |||
| if tool_use.name == "get_hints": # todo find more elegant solution to inject hints into moderator | |||
There was a problem hiding this comment.
could you help me understand what makes this not elegant? maybe include some details on the lifecycle of a hints tool?
There was a problem hiding this comment.
Feels a bit weird to make a case here for this particular tool use to then change the moderator state. Would maybe prefer if the tool could act on the moderator state directly?
ahau-square
force-pushed
the
ahau/context
branch
from
490f5dd
to
941c710
Compare
Co-authored-by: Michael Neale <[email protected]>
ahau-square
force-pushed
the
ahau/context
branch
from
840d41e
to
59abaf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning sketch of how Goose might retrieve context from a local context store via an additional tool call.
The local context store referenced is an interface to LanceDB as defined here: https://github.com/squareup/goose-context-store
The general idea is that based on a new task, Goose will first fetch relevant hints based on text and semantic queries to the local context store, and append those to its existing .goosehints as part of the system prompt.