Lifei/branch from ajgray #238
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
lifeizhou-ap
commented
Nov 12, 2024
| session_id_function = kwargs.pop("session_id") | ||
| session_id_value = session_id_function(fargs[0]) | ||
| modified_fn = self.session_id_wrapper(fn, session_id_value) | ||
| return langfuse_context.observe(*args, **kwargs)(modified_fn)(*fargs, **fkwargs) |
There was a problem hiding this comment.
wrap the update_current_trace call inside the observer wrapper
lifeizhou-ap
commented
Nov 12, 2024
| @wraps(fn) | ||
| def wrapped_fn(*fargs, **fkwargs) -> Callable: # noqa: ANN002, ANN003 | ||
| # group all traces under the same session | ||
| if "session_id" in kwargs: |
There was a problem hiding this comment.
used the session_id param in decorator instead of checking the function name "reply". (This is not related to the issue)
lifeizhou-ap
commented
Nov 12, 2024
| @@ -211,12 +207,9 @@ def run(self, new_session: bool = True) -> None: | |||
| time_end = datetime.now() | |||
| self._log_cost(start_time=time_start, end_time=time_end) | |||
|
|
|||
| @observe_wrapper() | |||
| @observe_wrapper(session_id=lambda instance: instance.name) | |||
There was a problem hiding this comment.
added session_id function parameter in the decorator. This is not directly related to the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.