Shell command fail exit codes are not tool failures #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelneale
approved these changes
Nov 25, 2024
|
This conflicts with an outstanding change but will get this into a similar PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when bash tool had a failure exit status we said the tool succeeded but prefixed the output that there was an error. In the rust version we currently say the tool failed instead. This PR changes the output otherwise it prints 'Tool request failed:' in the ui just because cargo build etc failed which is 'normal operations'.
New output (note the info inside ``` is still presented, just
falsedoesn't put anything to stdout):Old output:
