feat: support stdin and text input in cli #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendytang
changed the title
wendytang
requested review from
jsibbison-square,
baxen,
meenalc and
lifeizhou-ap
baxen
approved these changes
Nov 26, 2024
| let mut stdin = String::new(); | ||
| io::stdin() | ||
| .read_to_string(&mut stdin) | ||
| .expect("Failed to read from stdin"); |
There was a problem hiding this comment.
nit: this works great when used in a pipe, but if someone does not use a pipe, pass --text or pass --instructions, then it sites there reading input until you hit CTRL-D or CTRL-C which is confusing.
Is there a way to detect not piping and error maybe?
This is also how old goose worked in the same setting, so maybe we can skip solving this for now
There was a problem hiding this comment.
it sounds easy, but i think the way to do it would be to spawn a thread and then poll the channel. I'll skip this for now.
https://stackoverflow.com/questions/30012995/how-can-i-read-non-blocking-from-stdin
jsibbison-square
approved these changes
Nov 26, 2024
wendytang
force-pushed
the
wtang/support_run_pipe
branch
from
dff8dd3
to
ee3f61f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support pipes and/or text input. Usage: