Merge pull request #8 from maxholman/fetchimpl

fix: overly strict types
block65 · Aug 6, 2024 · d6eb0d4 · d6eb0d4
2 parents 70b2821 + ecda3b3
commit d6eb0d4
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/Makefile b/Makefile
@@ -15,7 +15,7 @@ distclean: clean
 	rm -rf node_modules
 
 .PHONY: test
-test: node_modules
+test: node_modules dist
 	pnpm exec vitest
 
 .PHONY: test.update

diff --git a/lib/command.ts b/lib/command.ts
@@ -3,15 +3,15 @@ import type { JsonifiableObject } from 'type-fest/source/jsonifiable.js';
 import type { HttpMethod } from './types.js';
 
 type Middleware<
-  CommandInput extends JsonifiableObject | undefined,
-  CommandOutput extends Jsonifiable | undefined,
+  CommandInput extends JsonifiableObject | undefined = never,
+  CommandOutput extends Jsonifiable | undefined = never,
 > = (input: CommandInput, output: CommandOutput) => CommandOutput;
 
 export abstract class Command<
-  CommandInput extends JsonifiableObject | undefined,
-  CommandOutput extends Jsonifiable | undefined,
-  CommandBody extends Jsonifiable | undefined,
-  CommandQuery extends JsonifiableObject | undefined,
+  CommandInput extends JsonifiableObject | undefined = never,
+  CommandOutput extends Jsonifiable | undefined = never,
+  CommandBody extends Jsonifiable | undefined = never,
+  CommandQuery extends JsonifiableObject | undefined = never,
 > {
   public method: HttpMethod = 'get';
 

diff --git a/test/test1.test.ts b/test/test1.test.ts
@@ -11,10 +11,10 @@ import {
 import { BillingCountry } from './fixtures/test1/types.js';
 
 async function thisAlwaysThrows<
-  CommandInput extends JsonifiableObject | undefined,
-  CommandOutput extends Jsonifiable | undefined,
-  CommandBody extends Jsonifiable | undefined,
-  CommandQuery extends JsonifiableObject | undefined,
+  CommandInput extends JsonifiableObject | undefined = never,
+  CommandOutput extends Jsonifiable | undefined = never,
+  CommandBody extends Jsonifiable | undefined = never,
+  CommandQuery extends JsonifiableObject | undefined = never,
 >(
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   _: Command<CommandInput, CommandOutput, CommandBody, CommandQuery>,