Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edge browser "Zero or duplicate tokens or token signing keys" error #14

Merged
merged 3 commits into from
Aug 1, 2024
Merged

fix: edge browser "Zero or duplicate tokens or token signing keys" error #14

merged 3 commits into from
Aug 1, 2024

Conversation

maxholman
Copy link
Contributor

@maxholman maxholman commented Jul 29, 2024 •
edited
Loading

Todo:

  • Chrome seems flaky with this change implemented. Arbitrarily responds with "invalid jwt"
  • Microsoft are very diligent with pruning test subscriptions in Edge. Need to create one that doesnt get nuked (this is the cause of current build failure)

fixes #13

@CetinSert
Copy link

CetinSert commented Jul 29, 2024 •
edited
Loading

@maxholman → Thank you!

This will close a long standing bug with push.rt.ht (uses web components (<push-notification>) and Cloudflare Workers for Platforms).

@maxholman maxholman merged commit 02d16ac into block65:master Aug 1, 2024
3 checks passed
@maxholman
Copy link
Contributor Author

Flakiness has magically subsided, and the edge subscription is no longer returning 410 Gone 🤷🏻

So just added some extra header checks. Tests are passing.

@maxholman maxholman deleted the github13 branch December 15, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not work with wns2-pn1p.notify.windows.com (Windows Notification Service)
2 participants
@maxholman @CetinSert