Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK update #70

Merged
merged 16 commits into from
Dec 18, 2023
Merged

SDK update #70

merged 16 commits into from
Dec 18, 2023

Conversation

slowbackspace
Copy link
Collaborator

@slowbackspace slowbackspace commented Nov 29, 2023

close #68

Added

  • added mempool methods: Mempool, MempoolAll, MempoolTx, MempoolByAddress, MempoolByAddressAll
  • added TransactionEvaluate and TransactionEvaluateUTXOs
  • added AddressUTXOsAsset and AddressUTXOsAssetAll (orig PR Add AddressUTXOsAsset and AddressUTXOsAssetAll functions #65)
  • added VerifyWebhookSignature for Webhooks
  • added BlocksAddresses for list of addresses affected by a specific block
  • missing epoch parameters

Fixed

  • fixed all test fixtures
  • fixed nullable types: nullable fields are now defined as pointers so go will use nil instead of setting these fields to their default value based on data type (eg. "" for string fields that actually null in JSON response)
  • fixed TransactionUTXOs type

Changed

  • updated CI actions
  • small refactor of *All methods
  • updated dependencies
  • min go version set to 1.21

@slowbackspace slowbackspace force-pushed the chore/23-update branch 2 times, most recently from 8ec8c4a to 430b403 Compare December 3, 2023 22:35
@slowbackspace slowbackspace marked this pull request as ready for review December 3, 2023 22:56
Copy link
Contributor

@jybp jybp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this.

BTW 2 tests fail locally when using a
BLOCKFROST_IPFS_PROJECT_ID with NETWORK: IPFS and a BLOCKFROST_PROJECT_ID with NETWORK: Cardano mainnet. 🤔

go test ./...
?   	github.com/blockfrost/blockfrost-go/example/accounts	[no test files]
?   	github.com/blockfrost/blockfrost-go/example/addresses	[no test files]
?   	github.com/blockfrost/blockfrost-go/example/basic	[no test files]
?   	github.com/blockfrost/blockfrost-go/example/genesis	[no test files]
?   	github.com/blockfrost/blockfrost-go/example/ipfs	[no test files]
?   	github.com/blockfrost/blockfrost-go/example/metadata	[no test files]
?   	github.com/blockfrost/blockfrost-go/example/nutlink	[no test files]
?   	github.com/blockfrost/blockfrost-go/example/pools	[no test files]
?   	github.com/blockfrost/blockfrost-go/example/scripts	[no test files]
?   	github.com/blockfrost/blockfrost-go/example/scripts/scripts_dump	[no test files]
?   	github.com/blockfrost/blockfrost-go/internal/version	[no test files]
WARNING: Cannot parse part of the signature header, key "v42" is not supported by this version of Blockfrost SDK.
--- FAIL: TestResourceMetricsIntegration (0.06s)
    api_metrics_test.go:22: got null []
--- FAIL: TestResourceMetricsEndpointsIntegration (0.09s)
    api_metrics_test.go:38: got null []
FAIL
FAIL	github.com/blockfrost/blockfrost-go	8.499s
FAIL

api_block.go Show resolved Hide resolved
Copy link
Contributor

@jybp jybp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

go test ./...
ok  	github.com/blockfrost/blockfrost-go	13.499s

@slowbackspace slowbackspace merged commit 3cdc7c6 into master Dec 18, 2023
1 check passed
@slowbackspace slowbackspace deleted the chore/23-update branch January 10, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specs of Blockfrost API missing
3 participants