fix(stats): 'no data' for grafana chart errors count (#1039)

* initialize counter to 0 to avoid 'no data' in grafana

* reorg integration tests to allow parallel run

stats/stats-server/src/server.rs

@@ -13,6 +13,7 @@ use anyhow::Context;
 use blockscout_endpoint_swagger::route_swagger;
 use blockscout_service_launcher::launcher::{self, LaunchSettings};
 use sea_orm::{ConnectOptions, Database};
+use stats::metrics;
 use stats_proto::blockscout::stats::v1::{
     health_actix::route_health,
     health_server::HealthServer,
@@ -111,6 +112,10 @@ pub async fn stats(settings: Settings) -> Result<(), anyhow::Error> {
             .await;
     });
 
+    if settings.metrics.enabled {
+        metrics::initialize_metrics(charts.charts_info.keys().map(|f| f.as_str()));
+    }
+
     let read_service = Arc::new(ReadService::new(db, charts, settings.limits.into()).await?);
     let health = Arc::new(HealthService::default());
 

stats/stats-server/tests/it/common.rs

@@ -0,0 +1,15 @@
+use reqwest::{RequestBuilder, Response};
+
+pub async fn send_arbitrary_request(request: RequestBuilder) -> Response {
+    let response = request
+        .send()
+        .await
+        .unwrap_or_else(|_| panic!("Failed to send request"));
+
+    if !response.status().is_success() {
+        let status = response.status();
+        let message = response.text().await.expect("Read body as text");
+        panic!("Invalid status code (success expected). Status: {status}. Message: {message}")
+    }
+    response
+}

stats/stats-server/tests/counters.rs → stats/stats-server/tests/it/counters.rs

@@ -3,9 +3,11 @@ use blockscout_service_launcher::{
     test_server::{get_test_server_settings, init_server, send_get_request},
 };
 use chrono::NaiveDate;
+
 use stats::tests::{init_db::init_db_all, mock_blockscout::fill_mock_blockscout_data};
 use stats_proto::blockscout::stats::v1::Counters;
 use stats_server::{stats, Settings};
+
 use std::{collections::HashSet, path::PathBuf, str::FromStr};
 
 #[tokio::test]

stats/stats-server/tests/it/main.rs

@@ -0,0 +1,5 @@
+mod common;
+
+mod counters;
+mod lines;
+mod swagger;

stats/stats-server/tests/swagger.rs → stats/stats-server/tests/it/swagger.rs

@@ -3,24 +3,13 @@ use blockscout_service_launcher::{
     test_server::{get_test_server_settings, init_server},
 };
 use pretty_assertions::assert_eq;
-use reqwest::{RequestBuilder, Response};
+
 use stats::tests::init_db::init_db_all;
 use stats_server::{stats, Settings};
+
 use std::{path::PathBuf, str::FromStr};
 
-async fn send_arbitrary_request(request: RequestBuilder) -> Response {
-    let response = request
-        .send()
-        .await
-        .unwrap_or_else(|_| panic!("Failed to send request"));
-
-    if !response.status().is_success() {
-        let status = response.status();
-        let message = response.text().await.expect("Read body as text");
-        panic!("Invalid status code (success expected). Status: {status}. Message: {message}")
-    }
-    response
-}
+use crate::common::send_arbitrary_request;
 
 #[tokio::test]
 #[ignore = "needs database"]

stats/stats/src/metrics.rs

@@ -23,3 +23,10 @@ lazy_static! {
     )
     .unwrap();
 }
+
+pub fn initialize_metrics<'a>(enabled_chart_keys: impl IntoIterator<Item = &'a str>) {
+    for chart_id in enabled_chart_keys {
+        UPDATE_ERRORS.with_label_values(&[chart_id]).reset();
+        // making zero observation for histograms doesn't make sense
+    }
+}