Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(libs): update blockscout db entities to 6.8.0 state #1041

Merged
merged 11 commits into from
Sep 10, 2024
Merged

chore(libs): update blockscout db entities to 6.8.0 state #1041

merged 11 commits into from
Sep 10, 2024

Conversation

bragov4ik
Copy link
Contributor

No description provided.

@bragov4ik bragov4ik linked an issue Aug 30, 2024 that may be closed by this pull request
Upgrade to sea-orm v1 #1042
Closed
@bragov4ik
Copy link
Contributor Author

this doesn't work because

  • accounts_tags table doesn't have primary key (easily fixable by hand here)
  • basically this issue

so, waiting for the latter to somehow resolve

@bragov4ik bragov4ik mentioned this pull request Aug 30, 2024
Closed
@bragov4ik bragov4ik mentioned this pull request Sep 6, 2024
Merged
@sevenzing
Copy link
Contributor

I suggest to add arguments for sea-orm-cli generate entity to specify tables to import and ignore accounts_tags for now

@bragov4ik
Copy link
Contributor Author

bragov4ik commented Sep 9, 2024 •
edited
Loading

to specify tables to import

you mean to exclude tables that face the referenced issue?

@sevenzing
Copy link
Contributor

yes

@bragov4ik bragov4ik force-pushed the bragov4ik/update-blockscout-db-entity branch from 42cd752 to cc88f4d Compare September 9, 2024 15:36
@bragov4ik bragov4ik mentioned this pull request Sep 10, 2024
Merged
@bragov4ik
Copy link
Contributor Author

just for the record: instead of excluding tables that didn't compile, I excluded columns that caused trouble

@bragov4ik bragov4ik force-pushed the bragov4ik/update-blockscout-db-entity branch 2 times, most recently from 7b044de to fd205eb Compare September 10, 2024 10:21
@bragov4ik bragov4ik force-pushed the bragov4ik/update-blockscout-db-entity branch from 4ba4796 to 8a3ab85 Compare September 10, 2024 13:06
@bragov4ik bragov4ik merged commit 64c9fb4 into main Sep 10, 2024
4 of 5 checks passed
@bragov4ik bragov4ik deleted the bragov4ik/update-blockscout-db-entity branch September 10, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koushiro koushiro koushiro left review comments

@sevenzing sevenzing sevenzing approved these changes

@lok52 lok52 Awaiting requested review from lok52

@rimrakhimov rimrakhimov Awaiting requested review from rimrakhimov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to sea-orm v1
3 participants
@bragov4ik @sevenzing @koushiro