Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stats): replace all ::float by ::TEXT #1071

Closed

Conversation

yjhmelody
Copy link
Contributor

No description provided.

yjhmelody and others added 2 commits September 29, 2024 10:18
Co-authored-by: Kirill Ivanov <8144358+bragov4ik@users.noreply.github.com>
@yjhmelody yjhmelody changed the title chore: improve averageGasPrice chore(stats): replace all ::float by ::TEXT Sep 29, 2024
@bragov4ik
Copy link
Contributor

I suggest to run tests locally before pushing to CI for easier development :)

@yjhmelody
Copy link
Contributor Author

I will close this PR. I will close this PR. since the float converts in rust side is different with pg side.

---- charts::counters::average_block_time::tests::update_average_block_time stdout ----
thread 'charts::counters::average_block_time::tests::update_average_block_time' panicked at stats/src/tests/simple_test.rs:368:5:
assertion failed: `(left == right)`

Diff < left / right > :
<802200.0833333334
>802200.083333333333

@yjhmelody yjhmelody closed this Oct 8, 2024
@yjhmelody yjhmelody reopened this Oct 8, 2024
@yjhmelody yjhmelody closed this Oct 8, 2024
@bragov4ik
Copy link
Contributor

you could modify tests to account for the precision errors (basically paste new values if they are very close)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants