Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add launcher test utils #627

Merged
merged 18 commits into from
Oct 16, 2023
Merged

Add launcher test utils #627

merged 18 commits into from
Oct 16, 2023

Conversation

lok52
Copy link
Contributor

@lok52 lok52 commented Oct 10, 2023

Add test utilities for launcher service:

  1. Generic TestDbGuard
  2. Server start-up utilities

@rimrakhimov
Copy link
Member

I suggest to make it two separate modules available under different set of features (test-database and test-server). For some cases (see eth-bytecode-db//tests) we may need to initialize only database without the server, and in that case it may make sense to use only one of the modules.

Also, maybe it would be possible to drop the database when the test fails? In my experience, it may be become a mess sometimes when you have lots of test cases persisting in the database from all kind of tests. I believe it may still be useful in some cases (but is not in most), so if we could set it explicitly on initialization if the database should be dropped (but drop it by default) would be really great. I'm not sure if that is possible, though

@lok52 lok52 force-pushed the lok52/launcher-test-utils branch from c5901a1 to 35fbeef Compare October 13, 2023 12:18
@lok52 lok52 force-pushed the lok52/launcher-test-utils branch from ffd6287 to 40206e8 Compare October 15, 2023 12:16
@lok52 lok52 force-pushed the lok52/launcher-test-utils branch from 40206e8 to 1779d66 Compare October 15, 2023 12:21
@lok52 lok52 force-pushed the lok52/launcher-test-utils branch from 6430c09 to 7911c99 Compare October 16, 2023 10:29
@lok52 lok52 merged commit 1521844 into main Oct 16, 2023
2 checks passed
@rimrakhimov rimrakhimov deleted the lok52/launcher-test-utils branch October 16, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants