Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced filter #1905

Merged
merged 14 commits into from
Dec 16, 2024
Merged

Advanced filter #1905

merged 14 commits into from
Dec 16, 2024

Conversation

isstuev
Copy link
Collaborator

@isstuev isstuev commented May 10, 2024

Description and Related Issue(s)

resolves #1794

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

@isstuev isstuev force-pushed the advanced-filter branch 2 times, most recently from ecf11ae to 94d075d Compare May 10, 2024 15:06
@isstuev isstuev force-pushed the advanced-filter branch from 94d075d to e1854c4 Compare May 10, 2024 16:00
@isstuev isstuev force-pushed the advanced-filter branch from e1854c4 to 69363a2 Compare May 13, 2024 19:49
@isstuev isstuev force-pushed the advanced-filter branch 2 times, most recently from 7dc52c6 to 4f507a1 Compare June 18, 2024 09:13
@isstuev isstuev force-pushed the advanced-filter branch 6 times, most recently from 4da37b2 to 0f5a5f6 Compare August 21, 2024 12:43
@isstuev isstuev force-pushed the advanced-filter branch 2 times, most recently from 10c5b47 to 4fa6b1a Compare August 21, 2024 13:17
@isstuev isstuev force-pushed the advanced-filter branch 2 times, most recently from efc9c7f to 3c8cf33 Compare August 21, 2024 15:06
@isstuev isstuev marked this pull request as ready for review December 6, 2024 17:45
@isstuev isstuev requested a review from tom2drum December 6, 2024 17:49
@github-actions github-actions bot added the feature New substantial feature label Dec 6, 2024
pages/advanced-filter.tsx Outdated Show resolved Hide resolved
ui/advancedFilter/ColumnFilterWrapper.tsx Show resolved Hide resolved
ui/pages/AdvancedFilter.pw.tsx Outdated Show resolved Hide resolved
ui/pages/AdvancedFilter.tsx Outdated Show resolved Hide resolved
ui/pages/AdvancedFilter.tsx Outdated Show resolved Hide resolved
ui/advancedFilter/filters/AssetFilter.tsx Show resolved Hide resolved
ui/advancedFilter/filters/AssetFilter.tsx Outdated Show resolved Hide resolved
ui/advancedFilter/filters/AssetFilter.tsx Outdated Show resolved Hide resolved
ui/advancedFilter/filters/AssetFilter.tsx Outdated Show resolved Hide resolved
ui/advancedFilter/filters/AssetFilter.tsx Outdated Show resolved Hide resolved
@isstuev isstuev requested a review from tom2drum December 11, 2024 23:33
Comment on lines +49 to +59
{ TABLE_COLUMNS.map(col => (
<Checkbox
key={ col.id }
defaultChecked={ columns[col.id] }
onChange={ onCheckboxClick }
id={ col.id }
size="lg"
>
{ col.id === 'or_and' ? 'And/Or' : col.name }
</Checkbox>
)) }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using the CheckboxGroup component would simplify the code.

@tom2drum tom2drum added the ENVs label Dec 13, 2024
@isstuev isstuev merged commit 8538b69 into main Dec 16, 2024
10 checks passed
@isstuev isstuev deleted the advanced-filter branch December 16, 2024 12:43
w875050772 added a commit to boolnetwork/boolscan that referenced this pull request Dec 23, 2024
…br-customized-retrofits-ultra

* 'ultra' of https://github.com/boolnetwork/boolscan: (1135 commits)
  Games (blockscout#2338)
  pools pages (blockscout#2468)
  Advanced filter (blockscout#1905)
  Call the API logout endpoint when the user logs out (blockscout#2469)
  Update Merits dashboard (blockscout#2456)
  Migrate from `web3modal` to `reown` (blockscout#2321)
  Support CDN for NFT images (blockscout#2461)
  change default description (blockscout#2470)
  Replace system selectors with Blockscout selectors style (blockscout#2451)
  [skip ci] fix favicon generator dev script
  fix(deploy-script): favicon generator (blockscout#2466)
  Support verification of Stylus contracts (blockscout#2450)
  fix block miner highlight style (blockscout#2459)
  SEO Tweaks for Gas Tracker Page (blockscout#2344)
  ReCaptcha: migrate back to v2 solution (blockscout#2446)
  Zilliqa: filter for Scilla contracts (blockscout#2449)
  Add Nouns pfps (blockscout#2447)
  Remove Canny from footer section (blockscout#2442)
  Scroll views (blockscout#2418)
  Improve grammar, capitalization, and consistency (blockscout#2432)
  ...

# Conflicts:
#	.eslintrc.js
#	.gitignore
#	configs/app/chain.ts
#	configs/app/ui.ts
#	configs/app/utils.ts
#	configs/envs/.env.main
#	deploy/tools/envs-validator/schema.ts
#	docs/ENVS.md
#	icons/clock-light.svg
#	icons/empty_search_result.svg
#	icons/wallet.svg
#	lib/api/buildUrl.ts
#	lib/api/resources.ts
#	lib/api/useApiQuery.tsx
#	lib/hooks/useFetch.tsx
#	lib/hooks/useNavItems.tsx
#	lib/metadata/getPageOgType.ts
#	lib/metadata/templates/description.ts
#	lib/metadata/templates/title.ts
#	lib/mixpanel/getPageType.ts
#	nextjs/nextjs-routes.d.ts
#	package.json
#	public/favicon/apple-touch-icon.png
#	public/favicon/favicon-16x16.png
#	public/favicon/favicon-32x32.png
#	public/favicon/favicon.ico
#	public/favicon_back/apple-touch-icon-120x120.png
#	public/favicon_back/apple-touch-icon-152x152.png
#	public/favicon_back/apple-touch-icon-180x180.png
#	public/favicon_back/apple-touch-icon-60x60.png
#	public/favicon_back/apple-touch-icon-76x76.png
#	public/favicon_back/safari-pinned-tab.svg
#	public/icons/name.d.ts
#	stubs/utils.ts
#	theme/foundations/colors.ts
#	types/api/transaction.ts
#	ui/address/contract/ContractConnectWallet.tsx
#	ui/home/Stats.tsx
#	ui/home/StatsItem.tsx
#	ui/home/indicators/ChainIndicators.tsx
#	ui/home/indicators/utils/indicators.tsx
#	ui/pages/Home.tsx
#	ui/shared/DetailsInfoItem.tsx
#	ui/shared/GasInfoTooltipContent/GasInfoRow.tsx
#	ui/shared/pagination/useQueryWithPages.ts
#	ui/snippets/footer/Footer.tsx
#	ui/snippets/navigation/vertical/NavigationDesktop.tsx
#	ui/snippets/searchBar/SearchBarInput.tsx
#	ui/snippets/topBar/ColorModeSwitch.tsx
#	ui/snippets/topBar/ColorModeSwitchTheme.tsx
#	ui/snippets/topBar/TopBarStats.tsx
#	ui/snippets/walletMenu/WalletMenuDesktop.tsx
#	ui/stats/NumberWidget.tsx
#	ui/stats/NumberWidgetsList.tsx
#	ui/stats/StatsDropdownMenu.tsx
#	ui/tx/TxInternals.tsx
#	ui/tx/internals/TxInternalsList.tsx
#	ui/tx/internals/TxInternalsTable.tsx
#	ui/txs/TxType.tsx
#	ui/txs/TxsTableItem.tsx
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENVs feature New substantial feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced Filters
2 participants