Fix read/write contract tooltip and stubs #2452
Closed
+16
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbol and decimals
tom2drum
requested changes
Dec 9, 2024
Comment on lines
+14
to
+16
| name: config.chain.currency.name ?? '', | ||
| symbol: config.chain.currency.symbol ?? '', | ||
| decimals: config.chain.currency.decimals, |
There was a problem hiding this comment.
We never show data from stubs to the user; they are solely used as placeholders for rendering skeletons correctly. Therefore, we would like to keep this data static without any configuration.
| @@ -25,7 +26,7 @@ const props: Props = { | |||
| ], | |||
| title: 'Native coin circulating supply', | |||
| description: 'Amount of token circulating supply for the period', | |||
| units: 'ETH', | |||
| units: currencyUnits.ether, | |||
There was a problem hiding this comment.
This data is returned by the Stats microservice and cannot be configured through the frontend app's environment variables. Therefore, this change is irrelevant.
| @@ -54,7 +55,7 @@ const ItemPrimitive = ({ abiParameter, data, level, hideLabel }: Props) => { | |||
| if (intMatch && typeof data === 'bigint' && intMatch.max > INT_TOOLTIP_THRESHOLD && data > INT_TOOLTIP_THRESHOLD) { | |||
| const dividedValue = BigNumber(data.toString()).div(WEI); | |||
| return ( | |||
| <Tooltip label={ dividedValue.toLocaleString() + ' ETH' }> | |||
| <Tooltip label={ dividedValue.toLocaleString() + ' ' + currencyUnits.ether }> | |||
There was a problem hiding this comment.
Generally, this value does not represent an amount of native currency. It could be any arbitrary number, such as the "total supply" of a token. So, I think using the native currency symbol here would be incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Related Issue(s)