Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/activate private ecs #4416

Open
wants to merge 820 commits into
base: main
Choose a base branch
from

Conversation

gbbayareametro
Copy link

@gbbayareametro gbbayareametro commented Oct 24, 2024

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This PR allows for the deployment and restart of the private API ECS service along with the others. It needs to be delivered along with my doorway-config PR

How Can This Be Tested/Reviewed?

The buildspec files and dev config file for the CICD codebase are the only things that changed and can be eyeballed. Other than that. See if it starts up the backend service after deploying.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

emilyjablonski and others added 30 commits June 5, 2024 18:24
* fix: fallback and refresh translations

* fix: commenting

* fix: remove logging

* fix: updated translation logic

* fix: add contentUpdatedAt field

* fix: seeding updates

* fix: add testing coverage

* fix: testing tweaks

* fix: context for new field

* fix: pr review cleanup
ColinBuyck and others added 28 commits October 2, 2024 16:32
* also add reusable layout footer to the household members page

(cherry picked from commit 29abe89)
* fix: if programs is null no longer errors

* fix: moving some stuff around to get test cov up
* fix: exposing more closed listings

* fix: update to use a new env variable
@gbbayareametro
Copy link
Author

Wrong repo. feel free to reject (I cant get rid of it apparently)

@ludtkemorgan
Copy link
Collaborator

@gbbayareametro I think this PR was accidentally opened up against Bloom Core instead of Doorway. For some reason Github defaults to that when creating a PR.

I'm assuming this is still a valid change, but unfortunately you'll need to close this one and reopen it in Doorway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants