refactor: max width layout #4500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyjablonski
commented
Dec 4, 2024
| @@ -20,24 +19,21 @@ const ErrorPage = () => { | |||
| }, [profile]) | |||
|
|
|||
| return ( | |||
| <Layout> | |||
There was a problem hiding this comment.
When this page was rendering (when the listing call fails on the listing view page) the header and footer were actually rendering twice.
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9 tasks
emilyjablonski
added
the
1 review needed
mcgarrye
approved these changes
Dec 5, 2024
mcgarrye
added
ready to merge
|
Is this good to merge @emilyjablonski? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A refactor based on Detroit work. We don't currently have a layout component unrelated to markdown content that sets up default page margin and padding. This PR adds that generic layout using Seeds tokens.
No related issue.
How Can This Be Tested/Reviewed?
In the places where we are using MarkdownSection where we aren't using markdown in the content, I transition to the MaxWidthLayout component.
You can compare an invalid link like https://bloom.exygy.dev/bonk to this PR's preview to see a place where the new layout is being used.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: