Fix compiler warnings seen in gcc 14.2.1

The latest version of gcc warns about a bunch of virtual destructors needed on non final types and some braces for subobject initialization. Signed-off-by: Pablo Galindo <[email protected]>
bloomberg · Oct 30, 2024 · 19b9759 · 19b9759
1 parent fdc89c6
commit 19b9759
Show file tree

Hide file tree

Showing 6 changed files with 224 additions and 199 deletions.
diff --git a/src/pystack/_pystack/elf_common.h b/src/pystack/_pystack/elf_common.h
@@ -59,7 +59,7 @@ class CoreFileAnalyzer : public Analyzer
     std::string locateLibrary(const std::string& lib) const;
 
     // Destructors
-    ~CoreFileAnalyzer();
+    virtual ~CoreFileAnalyzer();
 
     // Data members
     dwfl_unique_ptr d_dwfl;
@@ -84,6 +84,9 @@ class ProcessAnalyzer : public Analyzer
     // Constructors
     explicit ProcessAnalyzer(pid_t pid);
 
+    // Destructors
+    virtual ~ProcessAnalyzer() = default;
+
     // Methods
     const dwfl_unique_ptr& getDwfl() const override;
 

diff --git a/src/pystack/_pystack/process.h b/src/pystack/_pystack/process.h
@@ -150,6 +150,9 @@ class ProcessManager : public AbstractProcessManager
             std::vector<VirtualMap> memory_maps,
             MemoryMapInformation map_info);
 
+    // Destructors
+    virtual ~ProcessManager() = default;
+
     // Getters
     const std::vector<int>& Tids() const override;
 
@@ -169,6 +172,9 @@ class CoreFileProcessManager : public AbstractProcessManager
             std::vector<VirtualMap> memory_maps,
             MemoryMapInformation map_info);
 
+    // Destructors
+    virtual ~CoreFileProcessManager() = default;
+
     // Getters
     const std::vector<int>& Tids() const override;
 

diff --git a/src/pystack/_pystack/pyframe.cpp b/src/pystack/_pystack/pyframe.cpp
@@ -10,8 +10,6 @@
 #include "pytypes.h"
 #include "version.h"
 
-static constexpr int FRAME_LIMIT = 4096;
-
 namespace pystack {
 FrameObject::FrameObject(
         const std::shared_ptr<const AbstractProcessManager>& manager,

diff --git a/src/pystack/_pystack/pytypes.cpp b/src/pystack/_pystack/pytypes.cpp
@@ -494,7 +494,6 @@ GenericObject::toString(ssize_t max_size) const
 }
 
 NoneObject::NoneObject(remote_addr_t addr)
-: d_addr(addr)
 {
 }
 

diff --git a/src/pystack/_pystack/pytypes.h b/src/pystack/_pystack/pytypes.h
@@ -118,9 +118,6 @@ class NoneObject
 
     // Methods
     std::string toString(ssize_t max_size) const;
-
-  private:
-    remote_addr_t d_addr;
 };
 
 class Object