Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings for promise-mem #8

Merged
merged 2 commits into from
May 6, 2024
Merged

Add typings for promise-mem #8

merged 2 commits into from
May 6, 2024

Conversation

gndelia
Copy link
Contributor

@gndelia gndelia commented May 3, 2024

As I need to use promise-mem in a Typescript repo, It is better if we add the typings for it. I also added tsd to easily test that the types are correctly generated (as having some compile code that uses it). That way we can ensure types do not break if changed.

Version was incremented to 1.0.2

Process checklist

  • Manual tests passed or not applicable.
  • Automated tests added or not applicable.
  • Documentation updated or not required.

Metrics

Actual effort: 1h

@gndelia gndelia self-assigned this May 3, 2024
@gndelia gndelia requested a review from gabmontes as a code owner May 3, 2024 22:42
@gndelia gndelia enabled auto-merge May 6, 2024 14:40
@gndelia gndelia requested review from leanazulyoro and mbonfoster May 6, 2024 14:40
@gndelia gndelia merged commit 738539e into master May 6, 2024
4 checks passed
@gndelia gndelia deleted the p-mem-types branch May 6, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants