-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: modular rewrite (#103) #135
Conversation
* this does not work yet * comments & documentation will be added once the rewrite is complete
* this doesn't do much yet and a lot of code was deleted, functionality will be gradually added back
Other things I'll probably do in this PR:
|
I wonder what this error's about. I'll probably remove wallpapers for now.
|
* I'm never trusting AI again!
(the problem was not wallpapers, it was this line, which now is obviously wrong after i read it and not just trust AI blindly) |
apparently it's not possible to return an array from a function (eventhough doing so would be nice)
This reverts commit c27685f. (get_yaml_array can't be used in modules since it reads from the $RECIPE_FILE)
oops, forgot this one there's currently no removing of the firstboot data, though, but that doesn't affect people much ig
…ller (#144) * fix(rpm-ostree): format string in optfix This fixes optfix and makes the symlink not broken * fix: change rpm-ostreed auto update policy in ublue-update installer
I've done some testing here and in a VM and read through the docs. Everything looks good, but still can't remove I'll drop a PR for the website repo soon, and then we can merge at the same time. |
Hello Xyny! Remember when the bling repo was made to dedupe some aspects in Startingpoint? Well, this PR makes it so every repo that uses the new Startingpoint project needs to have all it's modules inside of it. Maybe we could move them to the bling repo and clone them to the project. That would make it so no one needs to have the standard modules in their repos, and would also enable people to make repos just for their custom modules, e.g. someone could make a "ublue-unofficial-extensions" repo or something like that! Summarizing: Instead of having |
@tulilirockz I love that idea. I'll drop a bling PR, and make some modifications to the website PR to pull in the docs. I sent some more cluttered thoughts over on discord, but I think this is overall beneficial. The size of startingpoint would actually shrink. |
some modules authored by @gerblesh original source: blue-build/legacy-template#135
* feat: add startingpoint modules some modules authored by @gerblesh original source: blue-build/legacy-template#135 * docs: better readme for modules dir * docs: yafti deps * docs: sp more information * feat: startingpoint modules in container * docs: sentence structure, check sidebar
Also, this most likely is fixed now :) I just made it sure the /usr/share/wallpapers/ublue-os folder and it's parents get created in the rpm post-installation stage, check it out! |
feat!: modular rewrite (#103)
This is an ongoing WIP rewrite for startingpoint to make it more modular. Comments appreciated. Code will be running through shellcheck.
Made this a 1.0 goal since I wouldn't do a "first release" with a rewrite in the works. Think of the current version as a 0.9 which won't be getting any breaking changes or new features for as long as this is in the works.
Aiming for feature parity but cleaner config files.