Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the unselected chapter color #113

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

immadisairaj
Copy link
Contributor

@immadisairaj immadisairaj commented Feb 25, 2024

Closes: #105

The selected and unselected chapter has only difference of font weight. So, this commit changes the unselected color to a lighter variant.

The lighter variant uses Theme.of(context).hintColor.

Also, this commit adds the mouse cursor to click on hover of the chapters telling that it is clickable.

Light Theme Dark Theme
Screenshot 2024-02-25 at 14 10 39 Screenshot 2024-02-25 at 14 11 05

PS: The 2 checks are failing even before this commit

The selected and unselected chapter has only difference of font weight.
So, this commit changes the unselected color to a lighter variant.

Also, this commit adds the mouse cursor to click on hover of the
chapters telling that it is clickable.
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@spydon spydon requested a review from erickzanardo February 26, 2024 09:14
@spydon spydon merged commit 641861c into bluefireteam:main Mar 11, 2024
3 checks passed
@immadisairaj immadisairaj deleted the selected_chapter branch March 12, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better contrast between selected item and the rest in the list
2 participants