Rfcomm: Change dbus type signature to an int

[infirit]

Fixes: #2489

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[cschramm]

I'm still wondering why this did not come up yet. Are there any specific conditions that cause the error? 🤔

[infirit]

Not sure. I usually don't use serial devices/rfcomm so I probably never noticed. I completely relied on the the type annotation while I should have done at least a quick test.

[cschramm]

Oh, I get it. This only became an issue with 5ea6542, thus the 2.4 release. I expected an issue that we'd have had for much longer, but it's only due to the f-string.

[infirit]

Yeah, I assumed the type hint was correct. Maybe we can change the add_method function to require python types. We might then be able to change the annotation and be more specific than Callable[..., Any]. So mypy can help us (mostly me lol) spot these issues.

Maybe a TypeVar if we pass a proper type or maybe even simpler NewType of str for each dbus typestring 🤔

I may experiment with that when I'm done with the for main PR.

Edit: this looks like a solution but its 3.10 or later https://docs.python.org/3.10/library/typing.html#typing.ParamSpec