Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 2.4.4 #2515

Open
wants to merge 7 commits into
base: 2-4-stable
Choose a base branch
from
Open

Conversation

infirit
Copy link
Contributor

@infirit infirit commented Oct 17, 2024

Ive added #2514 and #2513 to the 2.4.4 milestone. Anything else you want to include?

I'll update this PR with the new commits and update the changelog.

@infirit infirit requested a review from cschramm October 17, 2024 23:59
@cschramm
Copy link
Member

I now have some doubts on #2514 🙈

#2481 #2486 and #2499 are all candidates to me as well. Small and useful, although mostly not fixes. Not enough for a 2.5 I'd say, though. I'm a bit undecided. 😄

@infirit
Copy link
Contributor Author

infirit commented Oct 18, 2024

I now have some doubts on #2514 🙈

No problem to revert it, I'll drop it from this PR.

#2481 #2486 and #2499 are all candidates to me as well. Small and useful, although mostly not fixes.

Sounds good to me, I'll cherry-pick them.

Not enough for a 2.5 I'd say, though. I'm a bit undecided. 😄

I would be OK with doing more releases for small changes. I have larger reworks sitting unfinished (I replaced os.path in TransferService with pathlib.Path, but there is a bug which i have been failing to fix for very many months now because dealing with file transfers is not fun 😅 ) and those would be prime candidates for a new major release.

Copy link

sonarcloud bot commented Oct 19, 2024

@infirit
Copy link
Contributor Author

infirit commented Oct 19, 2024

Dropped the switch change and added the 3 PR you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants