Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: components: GpsTrayMenu: First version #2713

Merged
merged 2 commits into from
Jun 20, 2024
Merged

core: components: GpsTrayMenu: First version #2713

merged 2 commits into from
Jun 20, 2024

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Jun 20, 2024 •
edited
Loading

Fix #1749

image

image

joaoantoniocardoso
joaoantoniocardoso reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a GPS to test, but it looks all right

@patrickelectric patrickelectric merged commit 3094f08 into bluerobotics:master Jun 20, 2024
6 checks passed
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jul 8, 2024
@ES-Alexander ES-Alexander mentioned this pull request Nov 11, 2024
Merged
@ES-Alexander ES-Alexander added docs-minimal Documentation exists but should be improved and removed docs-needed Change needs to be documented labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso left review comments

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

@JoaoMario109 JoaoMario109 Awaiting requested review from JoaoMario109

Assignees
No one assigned
Labels
docs-minimal Documentation exists but should be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

we should show if there is a gps signal positioning
3 participants
@patrickelectric @joaoantoniocardoso @ES-Alexander