Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyproject: Use hatchling as build system #39

Merged
merged 5 commits into from
Jul 29, 2024
Merged

pyproject: Use hatchling as build system #39

merged 5 commits into from
Jul 29, 2024

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Aug 4, 2023 •
edited
Loading

Well this works, but I would like the confirmation from the maturin team

PyO3/maturin#1714

@RaulTrombin
Copy link
Member

Already merged required changes: pypa/hatch#1018
Waiting a new release from hatch.

@RaulTrombin
Copy link
Member

@patrickelectric
https://github.com/pypa/hatch/releases/tag/hatchling-v1.19.0

@patrickelectric
Copy link
Member Author

@RaulTrombin thanks!

@patrickelectric patrickelectric marked this pull request as ready for review March 4, 2024 13:03
RaulTrombin
RaulTrombin reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@RaulTrombin RaulTrombin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install (using 'maturin develop') -> already compile and install alongside Python.

Just need to call hatch dev env

.github/workflows/action.yml Outdated Show resolved Hide resolved
.github/workflows/action.yml Outdated Show resolved Hide resolved
@patrickelectric
pyproject: Use hatchling as build system
3de997b 
Signed-off-by: Patrick José Pereira <[email protected]>
@patrickelectric
pyproject: Use Cargo.toml as version source
d4989ff 
Signed-off-by: Patrick José Pereira <[email protected]>
@patrickelectric
pyproject: Add build command to generate binds
62d0dda 
Signed-off-by: Patrick José Pereira <[email protected]>
@patrickelectric
pyproject: Add target wheel
5eb0c48 
Signed-off-by: Patrick José Pereira <[email protected]>
@patrickelectric patrickelectric force-pushed the build-maturin branch 2 times, most recently from a1fd04a to 7783ad3 Compare July 29, 2024 14:27
@patrickelectric
ci: Use hatch to build python
7783ad3 
Signed-off-by: Patrick José Pereira <[email protected]>
@RaulTrombin RaulTrombin merged commit c3e609e into bluerobotics:master Jul 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaulTrombin RaulTrombin RaulTrombin approved these changes

@joaoantoniocardoso joaoantoniocardoso Awaiting requested review from joaoantoniocardoso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickelectric @RaulTrombin