Update Examples #115
Merged
Update Examples #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zfields
commented
Sep 29, 2023
| // Note that both of these definitions are optional; just prefix either line | ||
| // with `//` to remove it. | ||
| // - Remove txRxPinsSerial if you wired your Notecard using I2C SDA/SCL pins | ||
| // instead of serial RX/TX |
There was a problem hiding this comment.
Removed comment, because it is not possible to easily use I2C without the library.
zfields
commented
Sep 29, 2023
| @@ -90,7 +87,6 @@ void loop() | |||
| static unsigned eventCounter = 0; | |||
| if (++eventCounter > 25) | |||
| { | |||
| txRxPinsSerial.println("Demo cycle complete. Program stopped. Press RESET to restart."); | |||
There was a problem hiding this comment.
The Serial channel is used to communicate with the Notecard, not to log.
zfields
commented
Sep 29, 2023
| @@ -168,16 +168,6 @@ void loop() | |||
| notecard.logDebug("performing sensor measurement\n"); | |||
| lastStatusMs = millis(); | |||
|
|
|||
| // Count the simulated measurements that we send to the cloud, and stop the | |||
There was a problem hiding this comment.
There is no reason to count and stop, because this demo is based on button presses.
zfields
commented
Sep 29, 2023
| @@ -109,18 +109,18 @@ jobs: | |||
| - ./examples/Example8_BinarySendReceive/Example8_BinarySendReceive.ino | |||
| - ./examples/Example9_BinarySendReceiveChunked/Example9_BinarySendReceiveChunked.ino | |||
| fully-qualified-board-name: | |||
| - STMicroelectronics:stm32:BluesW:pnum=SWAN_R5 | |||
There was a problem hiding this comment.
alphabetized the list; librarian style.
haydenroche5
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.