Update to latest note-c master. #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenroche5
commented
Jan 25, 2024
src/note-c/.github/workflows/ci.yml
Outdated
| @@ -124,6 +124,23 @@ jobs: | |||
| github-token: ${{ secrets.GITHUB_TOKEN }} | |||
| path-to-lcov: ./build/test/coverage/lcov.info | |||
|
|
|||
| run_low_mem_unit_tests: | |||
There was a problem hiding this comment.
Hmmm, this shouldn't be here. I'll change the update_note_c.sh script to delete src/note-c/.github in addition to the other folders we're already culling.
haydenroche5
force-pushed
the
update_note_c
branch
2 times, most recently
from
07948f4 to
cc02874
Compare
haydenroche5
changed the title
zfields
approved these changes
Jan 26, 2024
|
With yet another number handling PR open on note-c, I'm going to hold off on merging this. We're going to have to pull in note-c master again shortly. |
haydenroche5
force-pushed
the
update_note_c
branch
from
f783d87 to
d123c4a
Compare
git-subtree-dir: src/note-c git-subtree-split: bbb727d657aa4912e86620d874673e7a5680b53f
haydenroche5
force-pushed
the
update_note_c
branch
from
d123c4a to
354b641
Compare
|
@zfields This should be ready now. |
JAddIntToObject used to be a macro for JAddNumberToObject. Now it's its own function and takes a JINTEGER rather than a JNUMBER.
zfields
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.