Skip to content

Commit

Permalink
fix: apparently cannot reference the env context. Remove the wait-f…
Browse files Browse the repository at this point in the history
…or since the local tunnel check also tests connectivity to md5srv
  • Loading branch information
m-mcgowan committed Sep 8, 2023
1 parent 1700c18 commit b5f950b
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/notecard-binary-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
uses: actions/checkout@v3
- name: Generate ND5 Server Token
run: |
[ -n "$MD5SRV_TOKEN" ] || echo "MD5SRV_TOKEN=abc" >> $GITHUB_ENV
[ -n "$MD5SRV_TOKEN" ] || echo "MD5SRV_TOKEN=`uuidgen`" >> $GITHUB_ENV
- name: Check Env Vars
run: |
. scripts/check_runner_config.sh
Expand All @@ -71,9 +71,6 @@ jobs:
with:
run: |
bash ./scripts/runmd5srv.sh
wait-on: |
tcp:${{ env.MD5SRV_ADDRESS }}:${{ env.MD5SRV_PORT }}
wait-for: 1m
# When done this way, the background process is terminated at the end of the step,
# At least when running with `act`. The same may be true of github runners also.
Expand Down

0 comments on commit b5f950b

Please sign in to comment.