TS-534: Fix card.binary HIL testing. #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, don't review this yet. There are some kinks that need to be worked out. |
haydenroche5
force-pushed
the
hayden/fix_hil_tunneling
branch
8 times, most recently
from
71f186d to
53fc403
Compare
|
Doesn't imply all tests should pass now? |
haydenroche5
force-pushed
the
hayden/fix_hil_tunneling
branch
3 times, most recently
from
a65ba5c to
75a05a7
Compare
- Use a single PlatformIO command to build, upload, and test. Previously, we we did this in a few steps because of a problem where the Swan's serial port wasn't ready after uploading and so the test step would fail because it couldn't find the serial port. I was able to reduce this to one step by using the approach described here: platformio/platformio-core#3742 - Fix a Bash typo in the step that cleaned up the Notehub proxy route. - I reinstalled tunnelmole using npm on the Orange Pi, and it's working again. I really don't know what was wrong here. In order for run_tmole.sh to find the tmole executable, I had to add a couple lines to the start of the script so that npm packages are on PATH. - Upgrade the note-arduino version to latest.
haydenroche5
force-pushed
the
hayden/fix_hil_tunneling
branch
from
0a192f3 to
5615daa
Compare
haydenroche5
changed the title
zfields
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we did this in a few steps because of a problem where the Swan's serial port
wasn't ready after uploading and so the test step would fail because it couldn't
find the serial port. I was able to reduce this to one step by using the
approach described here: Add test start delay option platformio/platformio-core#3742
I really don't know what was wrong here. In order for run_tmole.sh to find the
tmole executable, I had to add a couple lines to the start of the script so that
npm packages are on PATH.