Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename non-public API #159

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: rename non-public API #159

wants to merge 2 commits into from

Conversation

zfields
Copy link
Collaborator

@zfields zfields commented Nov 9, 2024

No description provided.

haydenroche5
haydenroche5 approved these changes Nov 9, 2024
View reviewed changes
Copy link
Collaborator

@haydenroche5 haydenroche5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't bother reviewing all the test files. I assume if the tests are building and passing, you did everything right. :)

@haydenroche5
Copy link
Collaborator

I need to debug the HIL card.binary tests (again!). Cancelled the job here that was hung and disabled the workflow, for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haydenroche5 haydenroche5 haydenroche5 approved these changes

@Bucknalla Bucknalla Awaiting requested review from Bucknalla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zfields @haydenroche5