Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and Update a bunch of things #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Dylancyclone
Copy link

Hi! I've been working on a fork for a little while and thought I'd make a PR for some of the fixes I've come across.
Here are all the changes and some explanations for them:

  • Added automatic and manual refreshing
    • Nicer alternative to refreshing if editing tasks from another client, such as mobile
  • Added support for viewing subtasks
    • I saw this done in a previous commit, and noticed it was probably removed because there was no way to add subtasks from this site. Without this, it makes it difficult to read a list of tasks created on Google because the subtasks will be shuffled around with the regular tasks
  • Added descriptions on the main view
    • Copies the information from the "details" hover dialog and brings it right under the title of the task
  • Changed About modal
    • Includes the Hotkeys so that the user doesn't need to go to the GitHub page to find them
  • Changed a couple shortcuts that were intercepted by the browser
    • Certain commands like ctrl+E get intercepted by the browser, so they've been changed to something similar but usable
  • Fixed some cases where the tasks would be sorted incorrectly
    • Under certain conditions the sorting function would not be called, this fixes that
  • Fixed the app failing to save changes if too many changes are made at once
    • This was also reported in Incomplete tasks text #10. He found his own fix, but this simply makes it auto-save at longer intervals, so it can check for updates to the task after the previous request to Google has finished. Previously it could see a change while a request had already been sent to Google so it was unable to send another.
  • Made the app stretch to fill all available vertical space
    • Makes the sidebar look a lot nicer
  • Fix a couple typos

It's also worth noting that this is my first Pull Request, so please let me know if I've done something wrong or I should do something differently.

To make this easier, I'll list the changes as a changelog.

+Added automatic and manual refreshing
+Added support for viewing subtasks
*Changed About modal
*Changed a couple shortcuts that were intercepted by the browser
*Changed everything to be dark themed
*Fixed some cases where the tasks would be sorted incorrectly
*Made the app stretch to fill all available vertical space
… once plus a few fixes

Set homepage to "." in package.json so the build can be deployed to anywhere on a webserver, fixed description not being dimmed/crossed out on completed task, and updated README image to match what this branch looks like.
The due date of a task is stored in UTC time, so different time zones may cause the date to be off by one day.
This commit reverts a bunch of the personal changes I've made to the repo to bring it back to it's original style. I want to try my hand at creating a Pull Request, so the only difference between the original version and this commit are the actual fixes and improvements, no visual/personal choices like dark mode or changing dates from dd/mm/yyyy to mm/dd/yyy

Full changes:

+Added automatic and manual refreshing
+Added support for viewing subtasks
+Added descriptions on the main view
*Changed About modal
*Changed a couple shortcuts that were intercepted by the browser
*Changed everything to be dark themed
*Fixed some cases where the tasks would be sorted incorrectly
*Fixed the app failing to save changes if too many changes are made at once
*Made the app stretch to fill all available vertical space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant