Add sex to names (#467)

* Add name "Jesus" * Fix ISO language code Use "cmn" for Chinese. * Lowercase name * Update 'Michael' Add aliases and translation. Merge "mitch" with "michael" because mitch is an alias for Michael. Delete "mitch.json." * Add gender to name file specs Add gender to file specs in readme.md. Add tests to validate each JSON's gender value. * Update michael.json Resolve merge conflict by using main repo's version of JSON file. * Make sex field optional for now Comment out tests for sex field. They are failing because names in collection don't have that field. Issue #443 * Add tests to check validity of gender Tests run only on name files that contain a gender value. Issue #443 Update README.md to describe sex field as optional. * Update gender tests - Issue #443 Sex field now requires a value to pass test. Also: - Add error messages to explain why a test failed. - Remove test for checking whether a sex value is a string. It's duplicating part of the "should have correct structure" test. * Add sex to names - Issue #456 * Add sex to names - Issue #456
bluzi · Nov 10, 2017 · aca21bc · aca21bc
1 parent 32d9737
commit aca21bc
Show file tree

Hide file tree

Showing 71 changed files with 142 additions and 71 deletions.
diff --git a/collection/aaron.json b/collection/aaron.json
@@ -9,5 +9,6 @@
         "heb": "אהרן",
         "jpn": "アーロン",
         "rus": "аарон"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/abraham.json b/collection/abraham.json
@@ -7,5 +7,6 @@
         "por": "abrão",
         "aao": "ابراهيم",
         "spa": "abraham"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/adam.json b/collection/adam.json
@@ -44,5 +44,6 @@
         "deu": "adam",
         "aze": "adəm",
         "tha": "อดัม"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/agnes.json b/collection/agnes.json
@@ -10,5 +10,6 @@
         "jpn": "アグネス",
         "heb": "אגנס",
         "fra": "agnès"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/alan.json b/collection/alan.json
@@ -8,5 +8,6 @@
    ],
     "translations": {
         "fra": "alain"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/alex.json b/collection/alex.json
@@ -18,5 +18,6 @@
 		"spa": "alejo",
 		"lat": "alexius",
 		"heb": "אלכס"
-	}
+	},
+	"sex": "m"
 }
diff --git a/collection/alexander.json b/collection/alexander.json
@@ -14,5 +14,6 @@
 		"ita": "alessandro",
 		"tha": "อเล็กซานเดอร์",
 		"heb": "אלכסנדר"
-	}
+	},
+	"sex": "m"
 }
diff --git a/collection/ali.json b/collection/ali.json
@@ -8,5 +8,6 @@
         "heb": "עלי",
         "tur": "ali",
         "rus": "али"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/ana.json b/collection/ana.json
@@ -6,5 +6,6 @@
     ],
     "translations": {
       "rup": "aha"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/andy.json b/collection/andy.json
@@ -21,5 +21,6 @@
 		"fas": "اَندی",
 		"heb": "אנדי",
 		"zho": "安迪"
-	}
+	},
+	"sex": "m"
 }
diff --git a/collection/anna.json b/collection/anna.json
@@ -3,5 +3,6 @@
 	"meaning": "Anna is a Latin form of the Hebrew name Hannah, meaning \"favor\" or \"grace\" or \"beautiful\".",
 	"translations": {
 		"ces": "anna"
-	}
+	},
+	"sex": "f"
 }
diff --git a/collection/benedict.json b/collection/benedict.json
@@ -11,5 +11,6 @@
       "ces": "benedikt",
       "rus": "бенедикт",
       "por": "benedito"
-   }
+   },
+   "sex": "m"
 }
diff --git a/collection/benjamin.json b/collection/benjamin.json
@@ -11,5 +11,6 @@
         "pol": "benjamin",
         "por": "benjamin",
         "tha": "เบญจมิน"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/blake.json b/collection/blake.json
@@ -8,5 +8,6 @@
         "ukr": "блейк",
         "cmn": "布雷克",
         "aze": "bleyk"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/bonnie.json b/collection/bonnie.json
@@ -6,5 +6,6 @@
     ],
     "translations": {
         "fra": "bonne"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/brian.json b/collection/brian.json
@@ -5,5 +5,6 @@
         "bryan"
     ],
     "translations": {
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/bruno.json b/collection/bruno.json
@@ -11,5 +11,6 @@
         "rus": "бруно",
         "aze": "bruno",
         "tha": "บรูโน่้"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/carlos.json b/collection/carlos.json
@@ -9,5 +9,6 @@
         "jpn": "カーロス",
         "por": "carlos",
         "rus": "карлос"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/charles.json b/collection/charles.json
@@ -19,5 +19,6 @@
         "hrv": "karlo",
         "ita": "carlo",
         "cym": "siarl"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/christian.json b/collection/christian.json
@@ -6,5 +6,6 @@
     ],
     "translations": {
         "heb": "נוצרי"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/christine.json b/collection/christine.json
@@ -13,5 +13,6 @@
         "por": "cristina",
         "rus": "кристина",
         "spa": "christina"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/clayton.json b/collection/clayton.json
@@ -7,5 +7,6 @@
     "translations": {
         "spa": "clayton",
         "rus": "клэйтон"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/cody.json b/collection/cody.json
@@ -7,5 +7,6 @@
         "aze": "kodi",
         "jpn": "コーディ",
         "rus": "коди"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/dai.json b/collection/dai.json
@@ -3,5 +3,6 @@
     "meaning": "Japanese masculine name meaning \"great\", or \"big\"",
     "translations": {
         "jpn": "大" 
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/daniel.json b/collection/daniel.json
@@ -29,5 +29,6 @@
         "hye": "դանիել",
         "tha": "แดเนียล"
 
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/darko.json b/collection/darko.json
@@ -5,5 +5,6 @@
     "mkd": "дарко",
     "rus": "дарко",
     "tha": "ดาโก้"
-  }
+  },
+  "sex": "m"
 }
diff --git a/collection/dave.json b/collection/dave.json
@@ -12,5 +12,6 @@
         "pol": "dawid",
         "heb": "דויד",
         "rus": "дэйв"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/davison.json b/collection/davison.json
@@ -6,5 +6,6 @@
     ], 
     "translations": {
         "fra": "davison" 
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/denis.json b/collection/denis.json
@@ -6,6 +6,7 @@
         "ita": "denis",
         "fra": "denys",
         "por": "denis"
-    }
+    },
+    "sex": "m"
 }
 
diff --git a/collection/dennise.json b/collection/dennise.json
@@ -6,5 +6,6 @@
     ],
     "translations": {
         "por": "denise"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/diana.json b/collection/diana.json
@@ -5,5 +5,6 @@
         "dee"
     ],
     "translations": {
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/diego.json b/collection/diego.json
@@ -9,5 +9,6 @@
         "rus": "диего",
         "tha": "ดีเอโก",
         "por": "diego"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/duncan.json b/collection/duncan.json
@@ -4,5 +4,6 @@
     "translations": {
         "ghc": "donnchadh",
         "rus": "дункан"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/edward.json b/collection/edward.json
@@ -13,5 +13,6 @@
     "swe": "edvard",
     "dan": "edvard",
     "rus": "эдвард"
-   }
+   },
+   "sex": "m"
 }
diff --git a/collection/elijah.json b/collection/elijah.json
@@ -12,5 +12,6 @@
         "mkd": "илија",
         "rus": "илья",
         "spa": "elias"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/elizabeth.json b/collection/elizabeth.json
@@ -4,5 +4,6 @@
   "translations": {
       "heb": "אליזבת",
       "jpn": "エリザベス"
-  }
+  },
+  "sex": "f"
 }
diff --git a/collection/emily.json b/collection/emily.json
@@ -16,5 +16,6 @@
         "fas": "اِمیلی",
         "tha": "เอมิลี่",
         "spa": "emilia"
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/emma.json b/collection/emma.json
@@ -5,5 +5,6 @@
       "ema",
       "ima"
     ],
-    "translations": {}
+    "translations": {},
+    "sex": "f"
 }
diff --git a/collection/evan.json b/collection/evan.json
@@ -3,5 +3,6 @@
     "meaning": "A name of Welsh origin, a form of the name \"John\", meaning \"Yahweh is Gracious\".",
     "translations": {
         "hye": "יְהוֹחָנָן"   
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/fabio.json b/collection/fabio.json
@@ -5,5 +5,6 @@
     "translations": {
         "spa": "fábio",
         "por": "fábio"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/gabriel.json b/collection/gabriel.json
@@ -11,5 +11,6 @@
         "deu": "gabriel",
         "aze": "cəbrayıl",
         "pol": "gabriel"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/gabrielle.json b/collection/gabrielle.json
@@ -7,5 +7,6 @@
     ], 
     "translations": {
         "heb": "גבריאל" 
-    }
+    },
+    "sex": "f"
 }
diff --git a/collection/harry.json b/collection/harry.json
@@ -3,5 +3,6 @@
     "meaning": "English for \"Rules the Home\"",
     "translations": {
         "rus": "гарри"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/haseeb.json b/collection/haseeb.json
@@ -3,5 +3,6 @@
     "meaning": "Means \"noble\", \"respected\", or \"reckoner\" in Arabic.",
     "translations": {
         "ara": "حسيب"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/ian.json b/collection/ian.json
@@ -5,5 +5,6 @@
         "fra": "yan",
         "deu": "jan",
         "rus": "ян"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/igor.json b/collection/igor.json
@@ -8,5 +8,6 @@
         "pol": "igor",
         "hye": "իգոր",
         "por": "igor"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/immanuel.json b/collection/immanuel.json
@@ -7,5 +7,6 @@
     ],
     "translations": {
         "heb": "עמנואל"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/ivan.json b/collection/ivan.json
@@ -10,5 +10,6 @@
         "ukr": "іван",
         "fas": "ایوان",
         "spa": "iván"
-    }
+    },
+    "sex": "m"
 }
diff --git a/collection/jack.json b/collection/jack.json
@@ -10,5 +10,6 @@
     ],
     "translations": {
         "rus": "джек"
-    }
+    },
+    "sex": "m"
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,5 +5,6 @@ @@
             "bryan"
         ],
         "translations": {
-        }
+        },
+        "sex": "m"
     }